Auth metadata endpoint is always rooted. #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results329 tests ±0 320 ✅ - 1 3m 20s ⏱️ -25s Results for commit befc50e. ± Comparison against base commit 0da77fc. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
|
Suggestion: since URIBuilder has been removed from other places, and there is already a method to set the path for a URL (UriUtils), that method could be used instead. |
ohadbitt
reviewed
Dec 23, 2024
AsafMah
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Auth metadata endpoint is always relative to the root of the cluster