Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth metadata endpoint is always rooted. #404

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Auth metadata endpoint is always rooted. #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6879ea
Auth metadata endpoint is always rooted.
alonadam Dec 22, 2024
6199686
Ignore failing test.
alonadam Dec 22, 2024
befc50e
Use UriUtils instead of UriBuilder.
alonadam Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion data/src/main/java/com/microsoft/azure/kusto/data/auth/CloudInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ private static CloudInfo fetchImpl(String clusterUrl, @Nullable HttpClient given
CloudInfo result;
HttpClient localHttpClient = givenHttpClient == null ? HttpClientFactory.create(null) : givenHttpClient;
try {
HttpRequest request = new HttpRequest(HttpMethod.GET, UriUtils.appendPathToUri(clusterUrl, METADATA_ENDPOINT));
// Metadata endpoint is always on the root of the cluster
HttpRequest request = new HttpRequest(HttpMethod.GET, UriUtils.setPathForUri(clusterUrl, METADATA_ENDPOINT));
request.setHeader(HttpHeaderName.ACCEPT_ENCODING, "gzip,deflate");
request.setHeader(HttpHeaderName.ACCEPT, "application/json");

Expand Down
1 change: 1 addition & 0 deletions ingest/src/test/java/com/microsoft/azure/kusto/ingest/E2ETest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,7 @@ void testSameHttpClientInstance() throws DataClientException, DataServiceExcepti

}

@Disabled("This test is disabled because it relies on the path part of the cluster Uri which we now ignore")
@Test
void testNoRedirectsCloudFail() {
KustoTrustedEndpoints.addTrustedHosts(Collections.singletonList(new MatchRule("statusreturner.azurewebsites.net", false)), false);
Expand Down
Loading