refactor: make network response a sealed class #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaireDavis
reviewed
Sep 17, 2024
| @JsonKey(ignore: true) | ||
| /// Create a copy of SturdyHttpEvent | ||
| /// with the given fields replaced by the non-null parameter values. | ||
| @JsonKey(includeFromJson: false, includeToJson: false) |
There was a problem hiding this comment.
just curious why this freezed file changed so much when the only change in the base file was removing an import 🤔
There was a problem hiding this comment.
Likely because when I cloned and pub get'd, a different (higher) version of freezed was pulled than the one that generated the original file, and new code is generated with the newer version.
Because pana failed (version decreased) I'm looking at upgrading some packages anyway so that may help make that more intuitive.
There was a problem hiding this comment.
OK @ClaireDavis, should be good to go now!
|
/no-platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📰 Summary of changes
This PR changes
NetworkResponsefrom being a freezed model to being a propersealed class, allowing dart's switch/pattern matching syntax.🧪 Testing done
No functional behavior has changed, all tests should pass.