Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes failing PowerPC unit tests #1603

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bmourad01
Copy link
Contributor

The failing tests were all related to load/store instruction encodings. It seems that they accept a sign-extended 16-bit immediate offset in these cases, and the sign extension wasn't being performed by the lifter.

@bmourad01
Copy link
Contributor Author

cc @gitoleg The git history says you wrote all of this so I wanted to make sure that these changes make sense. I assume at one point the tests were passing.

@gitoleg
Copy link
Contributor

gitoleg commented May 6, 2024

@bmourad01

looks reasonable! But I have no idea why we didn't see this fail before

The manual says that this immediate is also sign-extended
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants