This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Cleanup Code #51
Merged
Cleanup Code #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is going to be rewritten in the future, step by step, tested along the way.
#48 forgot to remove usage of components in the demo opmodes.
Also print stacktraces on compilation errors.
This reverts commit 6c26c96. The --scan option requires opting-in to Gradle's terms of service. The complexity of configuring Gradle is not worth adding in Gradle build scans.
This was referenced Jan 22, 2024
Merged
Merged
|
After talking with @cadenceforney, it appears that this code fails to compile when running an older version of Android Studio. After referring to this table, this update requires Android Studio Hedgehog or later. |
Vif15
approved these changes
Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a lot of old code and updates the demo opmodes. I recommend pressing the "Commits" tab and inspecting the changes for each individual commit, since it's a mixed bag.
Additionally, it adds a Github Action that automatically builds pull requests so that we know they compile. It finally upgrades Gradle to version 8.2 and the minimum Java version to 17.
Please checkout this branch and build it yourself using Android Studio! It may break things and I need to know it works for you too.