This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Clean up RobotConfig #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They both ended up multiplying their values against the joystick x. I multiplied their values and opted to keep the ROTATE_SPEED config.
I feel it is better to treat the power as a percentage. The negative sign is more of an implementation detail which I thought fit better in TeleOpMain.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
RobotConfigproperties, so it is more clear what each things does.SLOW_MULTIPLIERconfig ever since it was removed in Box Movement #36.ROTATE_SPEEDandROTATION_GAINconfigs, since they literally both do the same thing.SLIDE_DOWN_POWERa positive number instead of a negative one. (It's then negated inTeleOpMain. See 9bfa02d.)