Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:[DEV-10112] Color contrast issue in horizontal bar charts #1816

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Atash3000
Copy link
Collaborator

[Replace With Ticket Number]

Testing Steps

Open Horizontal bar chart.
Add labels to the bars.
if bar color was blue the label used to be black and now it is white.
Update contrast globally. i hope it is not going to create issues on other projects.
Screenshot 2025-01-07 at 09 23 47

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@Atash3000 Atash3000 added this to the 4.25.1 milestone Jan 7, 2025
@Atash3000 Atash3000 requested a review from adamdoe January 7, 2025 14:28
@@ -7,7 +7,7 @@ import chroma from 'chroma-js'
*
* !important - DO NOT CHANGE.
*/
export const WCAG_TEXT_CONTRAST_RATIO = 4.5
export const WCAG_TEXT_CONTRAST_RATIO = 4.9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be updated since its used throughout the codebase. Can you verify what the color contrast is between the blue and black text is? I believe it passes the contrast checks. If higher contrast is needed, you could use the getColorContrast check in this file to set the colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants