Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:[DEV-10112] Color contrast issue in horizontal bar charts #1816

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
+1 −1
Open

FIX:[DEV-10112] Color contrast issue in horizontal bar charts #1816

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c046c4
[DEV-10112] Update contrast
Atash3000 Jan 7, 2025
0b53ffb
[DEV-10112] Merge branch 'dev' into feature/DEV-10112
Atash3000 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/helpers/cove/accessibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import chroma from 'chroma-js'
*
* !important - DO NOT CHANGE.
*/
export const WCAG_TEXT_CONTRAST_RATIO = 4.5
export const WCAG_TEXT_CONTRAST_RATIO = 4.9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be updated since its used throughout the codebase. Can you verify what the color contrast is between the blue and black text is? I believe it passes the contrast checks. If higher contrast is needed, you could use the getColorContrast check in this file to set the colors.

export const WCAG_NON_TEXT_CONTRAST_RATIO = 3.5

export const getContrastColor = (textColor: string, bgColor: string) => {
Expand Down
Loading