Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not test libpointmatcher master, but 1.3.1 #157

Merged
merged 1 commit into from
May 31, 2024

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented May 30, 2024

For the Ubuntu images (that are now Ubuntu 24.04, aka Noble Numbat), the master version of libpointmatcher does not work. See https://github.com/CGAL/cgal-testsuite-dockerfiles/actions/runs/9239645476/job/25419044232#step:3:10178

This PR switches to commit norlab-ulaval/libpointmatcher@e9a832d, that is described by Git as 1.3.1-178-ge9a832d (178 commits ahead of the tag 1.3.1).

@lrineau lrineau requested review from afabri and soesau May 30, 2024 15:19
@lrineau lrineau self-assigned this May 30, 2024
Copy link
Member

@soesau soesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way the version exactly matches the windows version and still has the yaml-cpp dependency included.

@lrineau lrineau removed the request for review from afabri May 31, 2024 07:36
@lrineau lrineau merged commit f93231d into CGAL:master May 31, 2024
8 checks passed
@lrineau lrineau deleted the Ubuntu-24.04 branch May 31, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants