Unbreak -icount mode for RISC-V. #243
Draft
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
reviewed
Dec 19, 2023
| * This breaks -icount because it triggers early deallocation of the TB. | ||
| * It seems that it is only required for logging anyway. | ||
| */ | ||
| /* cpu_restore_state(env_cpu(env), _host_return_address, false); */ |
There was a problem hiding this comment.
I believe this is needed to read PCC correctly - we need a cursor that is up to date. But maybe the PC is already saved, might be possible to just assert that pc is current instead of calling this function?
There was a problem hiding this comment.
I re-enabled this and I can't seem to be able to reproduce the -icount bug. I suspect one of the latest merges with upstream qemu changed the code that invalidates the TB. I am hitting a loop condition that seems to trigger an interrupt loop in CheriBSD with -icount auto though. This is an unrelated problem, but I'm not sure how we can fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.