Update spec file to include glTF extension #296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295
The main point of the
ValidFeatureIdAttributeWithByteStride.glb
file was to test the validation of theEXT_mesh_features
feature IDs in a glTF asset that involves abyteStride
in the respective buffer view.(This was mainly motivated by the earlier approach that manually extracted the accessor data, and where taking into account the byte stride caused the usual caveats. Now, the accessor values are read with glTF-Transform, meaning that we don't really care about the byte stride any more, and just rely on glTF-Transform delivering the right data)
The
.GLB
file was originally created by loading the.gltf
file into gltf.report, and exporting it again. But... this did cause the actualEXT_mesh_features
extension to be omitted, as pointed out in #295The updated file here was created programmatically, with the
EXTMeshFeatures
extension object of the 3D Tiles Tools being registered in the glTF-TransformNodeIO
, meaning that the extension information is retained when it is converted to a GLB with a byte stride.