Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec file to include glTF extension #296

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Jan 15, 2024

Fixes #295

The main point of the ValidFeatureIdAttributeWithByteStride.glb file was to test the validation of the EXT_mesh_features feature IDs in a glTF asset that involves a byteStride in the respective buffer view.

(This was mainly motivated by the earlier approach that manually extracted the accessor data, and where taking into account the byte stride caused the usual caveats. Now, the accessor values are read with glTF-Transform, meaning that we don't really care about the byte stride any more, and just rely on glTF-Transform delivering the right data)

The .GLB file was originally created by loading the .gltf file into gltf.report, and exporting it again. But... this did cause the actual EXT_mesh_features extension to be omitted, as pointed out in #295

The updated file here was created programmatically, with the EXTMeshFeatures extension object of the 3D Tiles Tools being registered in the glTF-Transform NodeIO, meaning that the extension information is retained when it is converted to a GLB with a byte stride.

@lilleyse lilleyse merged commit 1e8aa96 into main Jan 16, 2024
2 checks passed
@lilleyse lilleyse deleted the update-byte-stride-spec-file branch January 16, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidFeatureIdAttributeWithByteStride.glb not a 3D Tile
2 participants