-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: verify attestation gossip messages in batch #5729
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
changed the title
feat: verify attestataion gossip messages in batch
feat: verify attestation gossip messages in batch
Jul 5, 2023
This was referenced Jul 7, 2023
twoeths
force-pushed
the
tuyen/verify_gossip_messages_in_batch
branch
from
July 18, 2023 04:16
a830c42
to
447ba94
Compare
twoeths
force-pushed
the
tuyen/verify_gossip_messages_in_batch
branch
from
August 15, 2023 08:13
447ba94
to
8966fbb
Compare
twoeths
force-pushed
the
tuyen/verify_gossip_messages_in_batch
branch
from
August 17, 2023 03:05
71485cc
to
13040de
Compare
twoeths
force-pushed
the
tuyen/verify_gossip_messages_in_batch
branch
from
August 17, 2023 07:04
13040de
to
f1c5043
Compare
replaced by #5896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
verifyMultipleSignatures
- this includes aggregating pubkey and signatures and do a simpleaggregatedSignature.verify()
, this is the number from thebls.test.ts
performance testDescription
IndexedGossipQueue
, whenbeacon_attestation
gossip messages come, we index by attestation data base64, new param for this queueindexFn
: function to index to store as keyminChunkSize
: keys with at least min chunk size will be processed first, this is 32maxChunkSize
: get up tomaxChunkSize
to process in batch, this is 128validateGossipAttestationsSameAttData
function to verify attestations with the same attestation data:bls.verifySignatureSets
) withbatchable: false
Closes #5416
Test result
IndexedGossipQueue
works well: 0.06% cpu fornext()
and 0.28% foradd()
TODOs
validateGossipAttestationsSameAttData
take 15% of cpu time, verifying signatures on main thread seem only suitable for network thread (useWorker=true
)useWorker=false