Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase e2e env startup timeout #6396

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

nazarhussain
Copy link
Contributor

Motivation

Make the e2e tests stable.

Description

  • When E2E job failed on CI, it's often it's just the timeout for starting the e2e nodes.

Steps to test or reproduce

  • Run all tests.

@nazarhussain nazarhussain requested a review from a team as a code owner February 6, 2024 10:13
@nazarhussain nazarhussain self-assigned this Feb 6, 2024
@@ -6,7 +6,7 @@ function start_app() {
nohup node --loader ts-node/esm packages/cli/test/scripts/e2e_test_env.ts > test-logs/e2e-test-env/simulation.out 2>&1 &
echo $! > test-logs/e2e-test-env/simulation.pid
echo "Wait for the node to be ready"
npx wait-port -t 60000 0.0.0.0:5001
npx wait-port -t 120000 0.0.0.0:5001
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observed in last few weeks node startup time is increased, not sure why. If anyone have idea about any particular change which could effect this please share.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also had the observation that we get more timeouts in tests which did not happen previously, e.g. the keystore cache timeouts.

Maybe the runners are overloaded, I know we use those buildjet runners, who is managing them? I know that Afri changed them a while ago from default runner.

Copy link
Member

@nflaig nflaig Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @wemeetagain, maybe you have some clues. Also noting that we actually already use "self hosted" or rather external runners.

CI does not work on forked repos.

Requested labels: buildjet-4vcpu-ubuntu-2204
Job defined at: nflaig/lodestar/.github/workflows/test.yml@refs/pull/3/merge
Waiting for a runner to pick up this job...

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Merging #6396 (1eda555) into unstable (c4bf385) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #6396   +/-   ##
=========================================
  Coverage     60.14%   60.14%           
=========================================
  Files           407      407           
  Lines         46512    46512           
  Branches       1551     1551           
=========================================
  Hits          27975    27975           
  Misses        18505    18505           
  Partials         32       32           

@nazarhussain nazarhussain merged commit cb754f6 into unstable Feb 6, 2024
14 of 15 checks passed
@nazarhussain nazarhussain deleted the nh/fix-e2e-tests branch February 6, 2024 14:24
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.16.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants