-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase e2e env startup timeout #6396
Conversation
@@ -6,7 +6,7 @@ function start_app() { | |||
nohup node --loader ts-node/esm packages/cli/test/scripts/e2e_test_env.ts > test-logs/e2e-test-env/simulation.out 2>&1 & | |||
echo $! > test-logs/e2e-test-env/simulation.pid | |||
echo "Wait for the node to be ready" | |||
npx wait-port -t 60000 0.0.0.0:5001 | |||
npx wait-port -t 120000 0.0.0.0:5001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I observed in last few weeks node startup time is increased, not sure why. If anyone have idea about any particular change which could effect this please share.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also had the observation that we get more timeouts in tests which did not happen previously, e.g. the keystore cache timeouts.
Maybe the runners are overloaded, I know we use those buildjet
runners, who is managing them? I know that Afri changed them a while ago from default runner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @wemeetagain, maybe you have some clues. Also noting that we actually already use "self hosted" or rather external runners.
CI does not work on forked repos.
Requested labels: buildjet-4vcpu-ubuntu-2204
Job defined at: nflaig/lodestar/.github/workflows/test.yml@refs/pull/3/merge
Waiting for a runner to pick up this job...
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6396 +/- ##
=========================================
Coverage 60.14% 60.14%
=========================================
Files 407 407
Lines 46512 46512
Branches 1551 1551
=========================================
Hits 27975 27975
Misses 18505 18505
Partials 32 32 |
🎉 This PR is included in v1.16.0 🎉 |
Motivation
Make the e2e tests stable.
Description
Steps to test or reproduce