Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase e2e env startup timeout #6396

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix: increase e2e env startup timeout #6396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/run_e2e_env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function start_app() {
nohup node --loader ts-node/esm packages/cli/test/scripts/e2e_test_env.ts > test-logs/e2e-test-env/simulation.out 2>&1 &
echo $! > test-logs/e2e-test-env/simulation.pid
echo "Wait for the node to be ready"
npx wait-port -t 60000 0.0.0.0:5001
npx wait-port -t 120000 0.0.0.0:5001
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observed in last few weeks node startup time is increased, not sure why. If anyone have idea about any particular change which could effect this please share.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also had the observation that we get more timeouts in tests which did not happen previously, e.g. the keystore cache timeouts.

Maybe the runners are overloaded, I know we use those buildjet runners, who is managing them? I know that Afri changed them a while ago from default runner.

Copy link
Member

@nflaig nflaig Feb 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @wemeetagain, maybe you have some clues. Also noting that we actually already use "self hosted" or rather external runners.

CI does not work on forked repos.

Requested labels: buildjet-4vcpu-ubuntu-2204
Job defined at: nflaig/lodestar/.github/workflows/test.yml@refs/pull/3/merge
Waiting for a runner to pick up this job...

}

function stop_app() {
Expand Down
Loading