Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for [BUG] wrong workflow summary for async scans #133 #134

Conversation

ArnaudLacroix
Copy link

[BUG] wrong workflow summary for async scans #133

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change.

References

Include supporting link to GitHub Issue/PR number

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

[BUG] wrong workflow summary for async scans Checkmarx#133
@pedrompflopes pedrompflopes requested review from a team, pedrompflopes and igorlombacx and removed request for a team August 7, 2023 16:15
@igorlombacx
Copy link
Contributor

Thank you for your valuable contribution to this pull request. We appreciate your effort in addressing the outlined issue.

Currently, our team is diligently investigating and rigorously testing the proposed solution to ensure its compatibility, reliability, and performance within our codebase. This process is a crucial step in maintaining the overall quality of our software.

We kindly ask for your patience during this testing phase. Your input is crucial to the success of our project, and we are excited to collaborate with you to bring this enhancement to fruition. Rest assured, we will provide timely updates on the progress and outcome of our testing efforts.

Once again, thank you for your dedication to our project and for being an integral part of our development community.

Best regards,

Igor Lomba.

@ArnaudLacroix
Copy link
Author

ArnaudLacroix commented Aug 29, 2023

Hi @igorlombacx, @pedrompflopes, do you have any update??

@pedrompflopes
Copy link
Collaborator

Hi @ArnaudLacroix
We reviewed it internally, and we decide to change inside our ast-cli. We will create the markdown report with a message that the scan is still running, that way you can have a link back to the scan in the scan summary.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants