Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Covariant123Vector DSS for Hyperdiffusion tendency #2080

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Use Covariant123Vector DSS for Hyperdiffusion tendency #2080

merged 1 commit into from
Sep 18, 2023

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Sep 8, 2023 •
edited
Loading

Purpose

Try dss on Covariant123Vector in hyperdiffusion tendency

  • I have read and checked the items on the review checklist.

@sriharshakandala sriharshakandala changed the title Try dss on Covariant123Vector Use Covariant123Vector DSS for Hyperdiffusion tendency Sep 8, 2023
@simonbyrne
Copy link
Member

simonbyrne commented Sep 13, 2023 •
edited
Loading

Looks like an assertion in ClimaCore is failing:

AssertionError: S <: supportedvectortypes
  Stacktrace:
    [1] create_dss_buffer(data::ClimaCore.DataLayouts.VIJFH{ClimaCore.Geometry.Covariant123Vector{Float32}, 4, Array{Float32, 5}}, topology::ClimaCore.Topologies.Topology2D{ClimaComms.SingletonCommsContext{ClimaComms.CPUSingleThreaded}, ClimaCore.Meshes.EquiangularCubedSphere{ClimaCore.Domains.SphereDomain{Float32}, ClimaCore.Meshes.NormalizedBilinearMap}, Vector{CartesianIndex{3}}, Array{Int64, 3}, Vector{Tuple{Int64, Int64, Int64, Int64, Bool}}, Vector{Tuple{Int64, Int64, Int64, Int64, Bool}}, Vector{Tuple{Int64, Int64}}, Vector{Int64}, Vector{Tuple{Bool, Int64, Int64}}, Vector{Int64}, NamedTuple{(), Tuple{}}, Vector{Tuple{Int64, Int64}}}, perimeter::ClimaCore.Spaces.Perimeter2D{4}, local_geometry::ClimaCore.DataLayouts.IJFH{ClimaCore.Geometry.LocalGeometry{(1, 2), ClimaCore.Geometry.LatLongPoint{Float32}, Float32, StaticArraysCore.SMatrix{2, 2, Float32, 4}}, 4, Array{Float32, 4}}, local_weights::ClimaCore.DataLayouts.IJFH{Float32, 4, Array{Float32, 4}})

@sriharshakandala sriharshakandala force-pushed the sk/try_dss_cov123 branch 2 times, most recently from d95d14e to 87d91cc Compare September 18, 2023 17:58
@sriharshakandala
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 18, 2023
@bors
Try #2080:
5523c4a
@bors
Copy link
Contributor

bors bot commented Sep 18, 2023

try

Build failed:

@sriharshakandala
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 18, 2023
@bors
Try #2080:
6f91850
@simonbyrne
Copy link
Member

@sriharshakandala you don't need to bors try on ClimaAtmos, all tests run by default.

@bors
Copy link
Contributor

bors bot commented Sep 18, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@sriharshakandala sriharshakandala marked this pull request as ready for review September 18, 2023 19:58
@sriharshakandala
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Sep 18, 2023
@bors @sriharshakandala @simonbyrne
Merge #2080 #2091
e6f8b42 
2080: Use Covariant123Vector DSS for Hyperdiffusion tendency r=sriharshakandala a=sriharshakandala



2091: Use weak divergence in scalar advection r=simonbyrne a=simonbyrne



Co-authored-by: sriharshakandala <sriharsha.kvs@gmail.com>
Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 18, 2023

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Sep 18, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 64fd7d6 into main Sep 18, 2023
7 of 8 checks passed
@bors bors bot deleted the sk/try_dss_cov123 branch September 18, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne simonbyrne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
O1.1.1: 8 SYPD for dry Held Suarez
Development

Successfully merging this pull request may close these issues.
2 participants
@sriharshakandala @simonbyrne