Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate diagnostic edmf precomputed quants int 4 funcs #2286

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

trontrytel
Copy link
Member

No description provided.

@trontrytel trontrytel requested review from Sbozzolo and szy21 October 24, 2023 22:56
@trontrytel trontrytel self-assigned this Oct 24, 2023
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I prefer to keep Fields to be consistent with the rest of the code base. But I'm fine with this change if @Sbozzolo thinks it's a good idea.

src/cache/diagnostic_edmf_precomputed_quantities.jl Outdated Show resolved Hide resolved
src/cache/diagnostic_edmf_precomputed_quantities.jl Outdated Show resolved Hide resolved
src/cache/diagnostic_edmf_precomputed_quantities.jl Outdated Show resolved Hide resolved
src/cache/diagnostic_edmf_precomputed_quantities.jl Outdated Show resolved Hide resolved
@Sbozzolo
Copy link
Member

Thanks! I prefer to keep Fields to be consistent with the rest of the code base. But I'm fine with this change if @Sbozzolo thinks it's a good idea.

Fields would make search-and-replace operations easier, but I can see that it is highly redundant, so I don't have strong opinions.

@trontrytel trontrytel force-pushed the aj/edmf_cleanup_vol3 branch from e7c5d4f to 7d22d6b Compare October 25, 2023 15:45
@trontrytel trontrytel changed the title Separate diagnostic edmf precomputed quants int 4 funcs, Fields -> F Separate diagnostic edmf precomputed quants int 4 funcs Oct 25, 2023
@trontrytel trontrytel force-pushed the aj/edmf_cleanup_vol3 branch from 514f8e8 to 5f82225 Compare October 25, 2023 15:50
@trontrytel
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 25, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a1ca826 into main Oct 25, 2023
6 checks passed
@bors bors bot deleted the aj/edmf_cleanup_vol3 branch October 25, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants