-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old diagnostics and ClimaAnalysis
#2360
Conversation
83ca7b9
to
c907b08
Compare
b292770
to
222cc10
Compare
@charleskawczynski @szy21 @akshaysridhar I addressed the comments, feel free to have a look again when you have the chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a few more minor comments.
356f20b
to
e6f18ec
Compare
There seems to be a typo in |
e6f18ec
to
5c57f5f
Compare
Thanks! |
Now that the diagnostics are removed from the HDF5 file, there is no longer any difference between `save_to_disk` and `save_restart`. The functions are now consolidated into a single one that saves the state without loss of information.
5c57f5f
to
c4b9969
Compare
We don't need this, as we are already interpolating in the Remapper We also need the newer version of ClimaCore because it contains the fix for interpolation on face spaces
Without the diagnostics, save_to_disk and save_restart become identical. This commit removes save_restart and renames save_to_disk to a more descriptive and clear save_state_to_disk. This state is used for restarts or to inspect the content of the state
c4b9969
to
1821da9
Compare
Highlight of the changes:
This pull request the post-processing pipelines are (for the most part) moved to using ClimaAnalysis.
ClimaAnalysis
takes care of all the file processing and reading and provides rudimentary plotting capabilities (when loaded withCairoMakie
).Going forward, there's going to be a unified way to produce plots for buildkite runs, with each job getting its post-processing function.
The entire post-processing pipeline has been condensed to a single file:
ci_plots.jl
. This file defines methods for the functionwhere
jobid
is the id of the job for which the plots have to be produced.For example, the function for the single column runs are:
Most post-processing steps will look like this.
make_plots_generic
is a new function defined inci_plots
that drivesCairoMakie
Figure/Axis
creating and usesCairoMakieExt
inClimaAnalysis
for heatmap or line plots (automatically selected depending on the dimensionality of the variable) and pages the output. The output is saved in temporary PDFs, which are all merged together to produce a multi-page PDF. To do so, I addedPoppler_jll
to the example environment.Another change is with the buildkite artifacts. I collected all the files in two tar archives so that only up to three files are uploaded. This makes finding the
summary.pdf
easy and quick (otherwise one would have to hunt that file). To do so, I addedTar.jl
as an explicit dependency to the example environment. Note thatTar.jl
is required byPkg
.