Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old diagnostics and ClimaAnalysis #2360

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Remove old diagnostics and ClimaAnalysis #2360

merged 6 commits into from
Jan 4, 2024
+889 −3,121

Commits on Jan 4, 2024

  1. Add short_name to NetCDF attributes

    @Sbozzolo
    Sbozzolo committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    909fda0 View commit details
    Browse the repository at this point in the history

  2. Bump compat for CairoMakie

    @Sbozzolo
    Sbozzolo committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    895151d View commit details
    Browse the repository at this point in the history

  3. Remove restart functions 

    Now that the diagnostics are removed from the HDF5 file, there is no
longer any difference between `save_to_disk` and `save_restart`. The
functions are now consolidated into a single one that saves the state
without loss of information.
    @Sbozzolo
    Sbozzolo committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    500deef View commit details
    Browse the repository at this point in the history

  4. Remove old diagnostics

    @Sbozzolo
    Sbozzolo committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    9d68a0c View commit details
    Browse the repository at this point in the history

  5. Remove interpolation F2C 

    We don't need this, as we are already interpolating in the Remapper

We also need the newer version of ClimaCore because it contains the fix
for interpolation on face spaces
    @Sbozzolo
    Sbozzolo committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    7e62e17 View commit details
    Browse the repository at this point in the history

  6. Remove save_restart, rename save_to_disk 

    Without the diagnostics, save_to_disk and save_restart become identical.
This commit removes save_restart and renames save_to_disk to a more
descriptive and clear save_state_to_disk. This state is used for
restarts or to inspect the content of the state
    @Sbozzolo
    Sbozzolo committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    1821da9 View commit details
    Browse the repository at this point in the history