Use more concrete eltypes in diagnostics #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/ti_diag
branch
from
b35798a to
49b27b4
Compare
Sbozzolo
reviewed
Dec 5, 2023
|
Even if the allocations increased, I think that it is a good idea to have everything concrete, so I'd still go ahead with this PR. What do you think? |
Yeah, I suppose so, I'll rebase and update the numbers |
charleskawczynski
force-pushed
the
ck/ti_diag
branch
from
65c01f0 to
9145788
Compare
charleskawczynski
force-pushed
the
ck/ti_diag
branch
from
9145788 to
87ca79e
Compare
charleskawczynski
force-pushed
the
ck/ti_diag
branch
from
87ca79e to
c6a4530
Compare
charleskawczynski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
variableproperty ofScheduledDiagnosticIterationsconcretely typed, which may help with inference / allocations.