Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more concrete eltypes in diagnostics #2414

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Use more concrete eltypes in diagnostics #2414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/diagnostics/diagnostic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ include("diagnostics_utils.jl")
# have a geometric average. If more complex reduction are needed, this mechanism has to be
# changed.

struct ScheduledDiagnosticIterations{T1, T2, OW, F1, F2, PO}
variable::DiagnosticVariable
struct ScheduledDiagnosticIterations{T1, T2, OW, F1, F2, PO, T}
variable::DiagnosticVariable{T}
output_every::T1
output_writer::OW
reduction_time_func::F1
Expand Down Expand Up @@ -301,7 +301,7 @@ struct ScheduledDiagnosticIterations{T1, T2, OW, F1, F2, PO}

"""
function ScheduledDiagnosticIterations(;
variable::DiagnosticVariable,
variable::DiagnosticVariable{T},
output_every,
output_writer,
reduction_time_func = nothing,
Expand All @@ -322,7 +322,7 @@ struct ScheduledDiagnosticIterations{T1, T2, OW, F1, F2, PO}
pre_output_hook!;
units_are_seconds = false,
),
)
) where {T}

# We provide an inner constructor to enforce some constraints

Expand Down Expand Up @@ -352,7 +352,7 @@ struct ScheduledDiagnosticIterations{T1, T2, OW, F1, F2, PO}
F2 = typeof(reduction_space_func)
PO = typeof(pre_output_hook!)

new{T1, T2, OW, F1, F2, PO}(
new{T1, T2, OW, F1, F2, PO, T}(
variable,
output_every,
output_writer,
Expand Down
Loading