Move diagnostics preparation into callbacks #2643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/refactor_callbacks
branch
from
12b65e4 to
20daa95
Compare
Sbozzolo
reviewed
Feb 7, 2024
Sbozzolo
reviewed
Feb 7, 2024
charleskawczynski
force-pushed
the
ck/refactor_callbacks
branch
from
20daa95 to
2a1821c
Compare
Sbozzolo
approved these changes
Feb 7, 2024
charleskawczynski
force-pushed
the
ck/refactor_callbacks
branch
from
2a1821c to
34e63a0
Compare
charleskawczynski
force-pushed
the
ck/refactor_callbacks
branch
4 times, most recently
from
bd28f60 to
ef459c0
Compare
|
Something is breaking, and I must have missed something. My computer did crashed in-between making changes, so maybe not everything was saved. There's not actually that many changes, so I may just re-apply them to be safe. |
This was referenced Feb 8, 2024
I will look into this. |
auto-merge was automatically disabled
March 6, 2024 15:24
Merge queue setting changed
charleskawczynski
force-pushed
the
ck/refactor_callbacks
branch
from
ef459c0 to
c9df27e
Compare
|
Accidentally force pushed to this, it was pretty stale anyway, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2598.