Forcing for ISDAC #3025
Merged
Forcing for ISDAC #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
szy21
reviewed
May 17, 2024
haakon-e
force-pushed
the
he/isdac-les
branch
2 times, most recently
from
acbc977
to
08dc509
Compare
|
@akshaysridhar could you have a look at the config file and see if there's something I should change to make the test pass? I'm probably just misconfiguring resolution / time step / other knobs relative to a robust LES setup. |
|
Where is |
|
When I ran this, the simulation crashed in the first few iterations until I reduced the timestep to satisfy the cfl condition (thanks @akshaysridhar). |
jty53
reviewed
Aug 14, 2024
| @@ -189,3 +189,58 @@ function external_forcing_tendency!(Yₜ, Y, p, t, ::GCMForcing) | |||
|
|
|||
| return nothing | |||
| end | |||
|
|
|||
| # ISDAC external forcing (i.e. nudging) | |||
| external_forcing_cache(Y, external_forcing::ISDACForcing) = (;) # Don't need to cache anything | |||
There was a problem hiding this comment.
@Sbozzolo
Line is missing parameters argument.
jty53
previously requested changes
Aug 14, 2024
akshaysridhar
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
See CliMA/AtmosphericProfilesLibrary.jl#41 for forcing
To-do
Content