Add pre-commit hook definition + test #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norhh
reviewed
Aug 20, 2024
| description: Analyze EVM bytecode with Mythril | ||
| entry: myth | ||
| args: | ||
| - analyze |
There was a problem hiding this comment.
isn't this fairly restrictive to just one argument? Mythril has multiple commands
There was a problem hiding this comment.
Adding disassemble and read-storage might be worth it.
There was a problem hiding this comment.
yeah... didn't want to add a hook for each possible command ... all subcommands can be selected via setting (=overwriting) args on user side... maybe worth to add to the README
norhh
reviewed
Aug 21, 2024
Co-authored-by: Nikhil Parasaram <tommycjniko@gmail.com>
norhh
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
.pre-commit-hooks.yaml(+ doc + test), which allows other projects to run Mythril via pre-commit.pre-commit became pretty popular as framework to combine linters / code-formatters via hooks across different languages. It can be enabled as actual git hook or just used by running
pre-commit run -a. pre-commit does its own dependency management (+cashing) and installs each hook into its own isolated folder/env.pre-commit installs a hook by cloning the
repo, checking out the specified gitrev(=tag, branch, commit hash), parsing the .pre-commit-hooks.yaml and installing the hook (install method depending on the hook type).Tested also via my Mythril fork, see dbast/sol-press#17
Requires a new tagged release after the PR merge to be able to reference a tag that contains the hook definition.