-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit hook definition + test #1877
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
name: pre-commit | ||
|
||
on: | ||
push: | ||
branches: | ||
- master | ||
- develop | ||
tags: | ||
- '*' | ||
pull_request: | ||
paths: | ||
- .github/workflows/pre-commit-hooks-test.yml | ||
- .pre-commit-hooks.yaml | ||
- tests/pre-commit-hooks/* | ||
- requirements.txt | ||
- setup.py | ||
|
||
jobs: | ||
hooks-test: | ||
runs-on: ubuntu-latest | ||
name: test hooks | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: '3.12' | ||
- name: Install pre-commit | ||
run: | | ||
python -m pip install pre-commit | ||
- name: Test hooks | ||
run: | | ||
./tests/pre-commit-hooks/test.sh |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
- id: mythril | ||
name: Mythril | ||
description: Analyze EVM bytecode with Mythril | ||
entry: myth | ||
args: | ||
- analyze | ||
language: python | ||
types: ["solidity"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// SPDX-License-Identifier: Apache-2.0 | ||
pragma solidity ^0.8.26; | ||
|
||
contract Counter { | ||
uint256 public number; | ||
|
||
function setNumber(uint256 newNumber) public { | ||
number = newNumber; | ||
} | ||
|
||
function increment() public { | ||
number++; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -o errtrace -o nounset -o pipefail -o errexit | ||
|
||
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)" | ||
|
||
# Create temp working directory for mock repo | ||
MOCK_REPO=$(mktemp -d) | ||
if [[ ! "$MOCK_REPO" || ! -d "$MOCK_REPO" ]]; then | ||
echo "Could not create temp dir" | ||
exit 1 | ||
fi | ||
function cleanup { | ||
echo "Deleting temp working directory $MOCK_REPO" | ||
rm -rf "$MOCK_REPO" | ||
} | ||
trap cleanup EXIT | ||
|
||
# Filling the mock repo | ||
pushd "$MOCK_REPO" >/dev/null || exit 1 | ||
git init --initial-branch=master | ||
git config user.email "test@example.com" | ||
git config user.name "pre-commit test" | ||
cp "$SCRIPT_DIR/Counter.sol" . | ||
git add . | ||
git commit -m "Initial commit" | ||
|
||
# Run pre-commit inside the mock repo while referencing the mythril directory, | ||
# where the .pre-commit-hooks.yaml is located. | ||
pre-commit try-repo "$SCRIPT_DIR/../.." mythril --verbose --color=always --all-files |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this fairly restrictive to just one argument? Mythril has multiple commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
disassemble
andread-storage
might be worth it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah... didn't want to add a hook for each possible command ... all subcommands can be selected via setting (=overwriting)
args
on user side... maybe worth to add to the READMEThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added to the README