Update feast filter dropdown options on Source pages & general clean-up of source views #1711
+320
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify options in the feast dropdown to include the feast and the range of folios on which the feast appears, rather than a single option for each feast-folio pair. Remove duplicate tests of feast selector options on various views. Add single test for feast dropdown options. Refs: 1707
…request Fix behaviour of feast and folio dropdown selectors on Chant Edit page to show chants on a specific folio or for a specific feast so that the selector remains on the selected option. Fix blank headers for filtered lists of chants on Chant Edit page. Modify instructions on the Chant Edit page when no chant is selected (these has previously suggested that only full texts and volpiano was editable via that page; this has been corrected to note that all chant fields are editable). Modify SourceEditChantsView `get_object` method so that the edited chant is always set by pk rather than recency of creation. Previously, this had been effectively true when changes were made through the form, as Django parsed the URL parameter for chant pk into the request.GET queryset; however, since URL parameters cannot currently be set with the Django test client, tests of this views were relying on the recency of chant feature. Now tests and the live form rely on the same logic (the presence of a `pk` option in the form data itself). Reduce extraneous querysets in SourceEditChantsView. Refs: DDMAL#1707, DDMAL#1708
dchiller
force-pushed
the
i1707-feast-folio-filter
branch
from
22ad7b1
to
751e162
Compare
lucasmarchd01
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the feast dropdown on
SourceBrowseChants,SourceDetail, andSourceEditChantsviews. Rather than have one option for each feast-folio combination (that then returned results for all chants of the selected feast, regardless of folio), we have one option for feast and show the range of folios on which that feast appears. Feasts are presented in order of the folio of their first appearance in the source.Previous version of Source Detail page
New version of Source Detail page
Previously, the chant object to be updated was determined first by the presence of pk in the request parameters, and then, if no pk was present, by whatever chant in the source had most recently been created. In practice, edits to chants through the SourceEditChants view were always passed with a chant pk, so the second option did not ever seem to be used on the "live" site. On the other hand, all tests of this view made use of the second option. This discrepancy between "real-life" behaviour and tested behaviour seemed like a suboptimal situation, so I modified the view and tests to that a chant pk is always required.
Also implements two other minor refactorings and fixes of source-related pages:
Closes #1707. Closes #1708.