Allow edits to chants with no existing full text; fix browse source dropdown #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests to consistently use `make_fake_[model]` functions. Update use of these functions for the new argument structure. Fix various type and linting issues in `make_fakes`.
Fix intermittently failing test by increasing types of institutions tested in SourceListViewTest.test_ordering. Adjust expected ordering tuples to account for these institutions. Removes random assignment of a fake institutions `is_private_collector` field.
Modify options in the feast dropdown to include the feast and the range of folios on which the feast appears, rather than a single option for each feast-folio pair. Remove duplicate tests of feast selector options on various views. Add single test for feast dropdown options. Refs: 1707
…request Fix behaviour of feast and folio dropdown selectors on Chant Edit page to show chants on a specific folio or for a specific feast so that the selector remains on the selected option. Fix blank headers for filtered lists of chants on Chant Edit page. Modify instructions on the Chant Edit page when no chant is selected (these has previously suggested that only full texts and volpiano was editable via that page; this has been corrected to note that all chant fields are editable). Modify SourceEditChantsView `get_object` method so that the edited chant is always set by pk rather than recency of creation. Previously, this had been effectively true when changes were made through the form, as Django parsed the URL parameter for chant pk into the request.GET queryset; however, since URL parameters cannot currently be set with the Django test client, tests of this views were relying on the recency of chant feature. Now tests and the live form rely on the same logic (the presence of a `pk` option in the form data itself). Reduce extraneous querysets in SourceEditChantsView. Refs: DDMAL#1707, DDMAL#1708
Follow DDMAL#1712 and conform pagination styling of the browse chants templates to other filterable table templates.
Allow edits to chants that did not have an initial full text to be saved even if no full text is added. Add check for uniqueness of folio-c_sequence to the chant edit page. This requires inclusion of the chant source in the chant edit form: the form, view, and test are edited to add the source to the form. Refs: DDMAL#1696.
Moves validity checks on the Chant Create view to the Chant Create Form. Refs: DDMAL#1713.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be reviewed/merged after #1711
Closes #1715. Refs #1713. Closes #1696.