Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow edits to chants with no existing full text; fix browse source dropdown #1716

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Allow edits to chants with no existing full text; fix browse source dropdown #1716

wants to merge 4 commits into from

Commits on Dec 3, 2024

  1. fix(browse chants): use short_heading in source filter dropdown 

    Refs: DDMAL#1715
    @dchiller
    dchiller committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    e306886 View commit details
    Browse the repository at this point in the history

  2. fix(browse chants): conform browse chants template styling to DDMAL#1712 

    

Follow DDMAL#1712 and conform pagination styling of the browse chants templates to other filterable table templates.
    @dchiller
    dchiller committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    fb36a36 View commit details
    Browse the repository at this point in the history

  3. feat(edit chants): allow chant edit to save with no initial full text 

    Allow edits to chants that did not have an initial full text to be saved even if no full text is added.

Add check for uniqueness of folio-c_sequence to the chant edit page. This requires inclusion of the chant source in the chant edit form: the form, view, and test are edited to add the source to the form.

Refs: DDMAL#1696.
    @dchiller
    dchiller committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    00c8088 View commit details
    Browse the repository at this point in the history

  4. fix(chant create): move folio-sequence uniqueness check to Form obj 

    Moves validity checks on the Chant Create view to the Chant Create Form.

Refs: DDMAL#1713.
    @dchiller
    dchiller committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    d69a155 View commit details
    Browse the repository at this point in the history