Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test mei encoding #1077

Merged
merged 10 commits into from
Aug 25, 2023
Merged

Test mei encoding #1077

merged 10 commits into from
Aug 25, 2023

Conversation

MrMondrian
Copy link
Contributor

@MrMondrian MrMondrian commented Aug 24, 2023

Resolves: (#ID-of-the-issue)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

Adds state machine based test file for mei encoding.

FIRST TEST CASE: Syllables well formed

  • elements that should be outside syllable are outside syllable
  • elements that should be inside syllable are inside syllable
  • elements that can be either are in only after a neume is in

SECOND TEST CASE: zones and facsimile are a bijection

THIRD TEST CASE: Proceeds and follows

  • Every syllable has a syl XOR a follows
  • Every syllable with a proceeds has a follows immediately after
  • Every syllable with a follows has a proceeds immediately before

FOURTH TEST CASE: All bounding box coordinates are non-negative

Copy link
Contributor

@timothydereuse timothydereuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - i think the state machine was the right way to go for testing, it looks a lot more robust than what I was doing back in the day with libMEI.

still wish the build_mei file wasn't nearly a thousand lines long but I think it kinda has to be, so that's a good enough place to leave it.

@MrMondrian MrMondrian merged commit e9cafb4 into develop Aug 25, 2023
1 check passed
@MrMondrian MrMondrian deleted the test-mei-encoding branch August 25, 2023 00:53
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants