Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI fixes #1083

Merged
merged 3 commits into from
Oct 3, 2023
Merged

UI fixes #1083

merged 3 commits into from
Oct 3, 2023

Conversation

cadagong
Copy link
Contributor

@cadagong cadagong commented Sep 17, 2023 •
edited by softcat477
Loading

Resolves: (#1082)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

(Describe the changes you've made and the purpose of this PR)

  • Fix for modal windows not displaying on Safari!
  • UI updated and fixes all over the website.

malajvan
malajvan approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@malajvan malajvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@softcat477 softcat477 linked an issue Sep 18, 2023 that may be closed by this pull request
Rodan modal windows don't appear at all in Safari. #1082
Closed
@softcat477 softcat477 merged commit 7db8153 into develop Oct 3, 2023
1 check passed
softcat477 added a commit that referenced this pull request Nov 7, 2023
@softcat477
Revert "Merge pull request #1083 from DDMAL/ui-fixes"
8093977 
This reverts commit 7db8153.
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malajvan malajvan malajvan approved these changes

@softcat477 softcat477 softcat477 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rodan modal windows don't appear at all in Safari.
3 participants
@cadagong @softcat477 @malajvan