Skip to content

Commit

Permalink
Merge pull request #66 from DEIS-Tools/63-python-the-underflow-thread…
Browse files Browse the repository at this point in the history
…-does-not-stop-itself

63 python the underflow thread does not stop itself
  • Loading branch information
magoorden authored Aug 28, 2024
2 parents 883a013 + f5583f0 commit cdc5db3
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions py_driver/driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ def update_state(self, tube=None, quick=False, initial=False):
raise SensorError(f"Failed to retrieve new state, got {state}.")

def _underflow_check(self):
"""
Checks whether underflow occurs, i.e., the outflow pump is pumping while water is lower than
lowest allowed level. This check prevents the outflow pump from pumping air.
"""
TAG = "UNDERFLOW_CHECK"
while True:
if not self.ready():
Expand Down Expand Up @@ -274,6 +278,11 @@ def _underflow_check(self):
else:
if DEBUG:
print(f'{TAG}: No underflow detected in watchdog.')

# Stop checking underflow.
if self.stopped:
break

sleep(UNDERFLOW_CHECK_INTERVAL)

def _read_lines(self):
Expand Down

0 comments on commit cdc5db3

Please sign in to comment.