[R] Upgrade moto to 2.0.2 (#1718)

[amarjandu]

Author

• PR title references issue
• Title of main commit references issue
• PR is linked to Zenhub issue

Author (reindex)

• Added r tag to commit title _{or this PR does not require reindexing}
• Added reindex label to PR _{or this PR does not require reindexing}

Author (freebies & chains)

• Freebies are blocked on this PR _{or there are no freebies in this PR}
• Freebies are referenced in commit titles _{or there are no freebies in this PR}
• This PR is blocked by previous PR in the chain _{or this PR is not chained to another PR}
• Added chain label to the blocking PR _{or this PR is not chained to another PR}

Author (upgrading)

• Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading}
• Added u tag to commit title _{or this PR does not require upgrading}
• Added upgrade label to PR _{or this PR does not require upgrading}

Author (requirements, before every review)

• Ran make requirements_update _{or this PR leaves requirements*.txt, common.mk and Makefile untouched}
• Added R tag to commit title _{or this PR leaves requirements*.txt untouched}
• Added reqs label to PR _{or this PR leaves requirements*.txt untouched}

Author (before every review)

• make integration_test passes in personal deployment _{or this PR does not touch functionality that could break the IT}
• Rebased branch on develop, squashed old fixups

Primary reviewer (after approval)

• Commented on demo expectations _{or labelled PR as no demo}
• Decided if PR can be labeled no sandbox
• PR title is appropriate as title of merge commit
• Moved ticket to Approved column
• Assigned PR to an operator

Operator (before pushing merge the commit)

• Checked reindex label and r commit title tag
• Checked that Demo expectations are clear _{or PR is labeled as no demo}
• Rebased and squashed branch
• Sanity-checked history
• Pushed PR branch to Github
• Branch pushed to Gitlab and build passes in sandbox _{or added no sandbox label}
• Started reindex in sandbox _{or this PR does not require reindexing sandbox}
• Checked for failures in sandbox _{or this PR does not require reindexing sandbox}
• Added PR reference to merge commit title
• Collected commit title tags in merge commit title
• Moved linked issue to Merged column
• Pushed merge commit to Github

Operator (after pushing the merge commit)

• Moved freebies to Merged column _{or there are no freebies in this PR}
• Shortened the PR chain _{or this PR is not the base of another PR}
• Verified that N reviews labelling is accurate
• Pushed merge commit to Gitlab _{or this changes can be pushed later, together with another PR}
• Deleted PR branch from Github and Gitlab

Operator (reindex)

• Purchased BQ slot committment in dev _{or this PR does not require reindexing dev}
• Started reindex in dev _{or this PR does not require reindexing dev}
• Deleted BQ slot committment in dev _{or this PR does not require reindexing dev}
• Checked for failures in dev _{or this PR does not require reindexing dev}
• Purchased BQ slot committment in prod _{or this PR does not require reindexing prod}
• Started reindex in prod _{or this PR does not require reindexing prod}
• Deleted BQ slot committment in prod _{or this PR does not require reindexing prod}
• Checked for failures in prod _{or this PR does not require reindexing prod}

Operator

• Unassigned PR

[codecov]

Codecov Report

Merging #2886 (0df9bc7) into develop (caa3711) will decrease coverage by 0.10%.
The diff coverage is 88.67%.

@@             Coverage Diff             @@
##           develop    #2886      +/-   ##
===========================================
- Coverage    82.64%   82.54%   -0.11%     
===========================================
  Files          117      116       -1     
  Lines        12246    12180      -66     
===========================================
- Hits         10121    10054      -67     
- Misses        2125     2126       +1     

Impacted Files	Coverage Δ
test/service/test_collection_data_access.py	20.35% <0.00%> (-8.22%)	⬇️
test/test_doctests.py	95.74% <ø> (-0.09%)	⬇️
test/version_table_test_case.py	94.44% <ø> (ø)
src/azul/portal_service.py	85.59% <80.00%> (-1.14%)	⬇️
src/azul/service/storage_service.py	90.71% <100.00%> (ø)
test/azul_test_case.py	71.64% <100.00%> (ø)
test/health_check_test_case.py	98.42% <100.00%> (-0.09%)	⬇️
test/indexer/test_hca_indexer.py	99.38% <100.00%> (-0.01%)	⬇️
test/indexer/test_indexer_controller.py	100.00% <100.00%> (ø)
test/service/test_drs.py	97.76% <100.00%> (-0.07%)	⬇️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa3711...0df9bc7. Read the comment docs.

[coveralls]

Coverage decreased (-0.09%) to 83.077% when pulling 0df9bc7 on issues/amar/1718-moto-upgrade into caa3711 on develop.

[amarjandu]

• Verify sandbox IT passes
• Push commit merges to github PR branch

[hannes-ucsc]

See REVIEW commit. I did test the changes but they may have to be distributed over your existing commits. The change that removes the @contextmanager from _mock_service_endpoints should probably be a separate commit.

[hannes-ucsc]

Alternatively, it's ok if you leave my REVIEW commit in place and just make it the 9/9 commit with a subtitle of like "Refactor response mock usage in health check tests`

[amarjandu]

Alternatively, it's ok if you leave my REVIEW commit in place and just make it the 9/9 commit with a subtitle of like "Refactor response mock usage in health check tests`

I'll update the commit titles and refresh the transitive dependencies.

note: Hannes REVIEW commit hash 8284ba7237b5b4c7dbf7de5b82755773f6c28f15

[hannes-ucsc]

I think the passing tests are demonstration enough. I know how hard this was and don't want to strip you of the opportunity to show this off. If you WANT to demo this, feel free to do so and take the no demo label off.