Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AJ-1993 Expand File preview popup modal to allow easier viewing #5064

Merged
merged 5 commits into from
Sep 9, 2024
Merged

AJ-1993 Expand File preview popup modal to allow easier viewing #5064

merged 5 commits into from
Sep 9, 2024

Conversation

kevinmarete
Copy link
Contributor

Jira Ticket: https://broadworkbench.atlassian.net/browse/AJ-1993

What

  • This PR updates the file preview pop-up modal to include a dual-panel view, allowing users to see file details and contents side-by-side. It also allows users to resize the panels to suit their needs.

Why

  • There was a need to enable resizing of the preview panels due to varying widths of data.
  • We wanted to ensure the preview modal adapts well to different screen sizes.

Testing strategy

  • Tested dual-panel functionality and resizing on various file types and screen sizes.

No Preview
NoPreview

Portrait View (Default)
Portrait

Landscape View
Landscape

@kevinmarete kevinmarete self-assigned this Sep 7, 2024
@kevinmarete kevinmarete requested a review from a team as a code owner September 7, 2024 05:39
@calypsomatic
Copy link
Contributor

When I click on the arrow/expand button (at least in the case where the file can't be previewed), it breaks the page. If there's no preview maybe disable that button?

Screen.Recording.2024-09-09.at.10.56.56.AM.mov

calypsomatic
calypsomatic approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@calypsomatic calypsomatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-building fixed it!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

davidangb
davidangb approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I like it!

@kevinmarete kevinmarete added this pull request to the merge queue Sep 9, 2024
Merged via the queue into dev with commit 1ea783e Sep 9, 2024
10 checks passed
@kevinmarete kevinmarete deleted the km_AJ-1993_resize_preview branch September 9, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calypsomatic calypsomatic calypsomatic approved these changes

@davidangb davidangb davidangb approved these changes

Assignees

@kevinmarete kevinmarete

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinmarete @calypsomatic @davidangb @broadbot