Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run regression-detector on main, but make it a no-op #31099

Closed
wants to merge 2 commits into from
Closed

Run regression-detector on main, but make it a no-op #31099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dabd736
Run regression-detector on main, but make it a no-op
scottopell Nov 14, 2024
2cd01df
revert autoformat and use same rule for pr-comment step
scottopell Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,11 @@ workflow:
when: never
- !reference [.except_mergequeue]

.except_release_branch:
- <<: *if_release_branch
when: never
- !reference [.except_mergequeue]

.on_main_or_release_branch_or_deploy_always:
- <<: *if_deploy
when: always
Expand Down
7 changes: 5 additions & 2 deletions .gitlab/functional_test/regression_detector.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ single-machine-performance-regression_detector:
stage: functional_test
timeout: 1h10m
rules:
- !reference [.except_main_or_release_branch]
- !reference [.except_release_branch]
- when: on_success
image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
tags: ["arch:amd64"]
Expand All @@ -26,6 +26,9 @@ single-machine-performance-regression_detector:
# See 'decision_record.md' for the determination of whether this job passes or fails.
allow_failure: false
script:
# This job must run on the `main` branch for compatibility with github's required
# branch protection rules. This is a no-op for the `main` branch.
- $CI_COMMIT_BRANCH == "main" && echo "No-op for main branch" && exit 0
# Ensure output files exist for artifact downloads step
- mkdir outputs # Also needed for smp job sync step
# Compute merge base of current commit and `main`
Expand Down Expand Up @@ -187,7 +190,7 @@ single-machine-performance-regression_detector:
single-machine-performance-regression_detector-pr-comment:
stage: functional_test
rules:
- !reference [.except_main_or_release_branch]
- !reference [.except_release_branch]
- when: always
image:
name: "486234852809.dkr.ecr.us-east-1.amazonaws.com/pr-commenter:3"
Expand Down
Loading