Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/net/http: Make DD_TRACE_HTTP_CLIENT_TAG_QUERY_STRING false by default #3010

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Dec 5, 2024

What does this PR do?

By default, query string is not collected on http client spans.

Motivation

Without the ability to obfuscate the query string (like what DD_TRACE_OBFUSCATION_QUERY_STRING_REGEXP does for http server spans), collecting it by default poses a security risk. Thus, we are disabling it by default, allowing users to opt-in to the feature if they so choose.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@mtoffl01 mtoffl01 requested review from a team as code owners December 5, 2024 16:16
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Dec 5, 2024
@mtoffl01 mtoffl01 marked this pull request as draft December 5, 2024 16:20
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 5, 2024

Datadog Report

Branch report: mtoff/disalbe-client-querystring
Commit report: 88876ae
Test service: dd-trace-go

✅ 0 Failed, 5094 Passed, 67 Skipped, 2m 57.35s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 5, 2024

Benchmarks

Benchmark execution time: 2024-12-09 11:01:48

Comparing candidate commit a5b4b0e in PR branch mtoff/disalbe-client-querystring with baseline commit 79a1f60 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@mtoffl01 mtoffl01 marked this pull request as ready for review December 5, 2024 19:53
@mtoffl01 mtoffl01 marked this pull request as draft December 6, 2024 14:52
@mtoffl01 mtoffl01 marked this pull request as ready for review December 6, 2024 20:54
@mtoffl01 mtoffl01 enabled auto-merge (squash) December 9, 2024 19:24
@mtoffl01 mtoffl01 merged commit 1d2c8f1 into main Dec 9, 2024
161 of 162 checks passed
@mtoffl01 mtoffl01 deleted the mtoff/disalbe-client-querystring branch December 9, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants