🐛 Mark Web Vitals attribution fields as optional where appropriate #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cy-moi
approved these changes
Dec 24, 2024
thomas-lebeau
approved these changes
Dec 24, 2024
sethfowler-datadog
deleted the
seth.fowler/mark-web-vitals-attribution-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases we may be able to generate a score for a Web Vital, but not be able to generate some of its attribution data. This PR makes all attribution fields that the browser SDK can fail to generate optional. This both better reflects reality and aligns the types in the schema with the types used internally by the browser SDK.