Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Mark Web Vitals attribution fields as optional where appropriate #243

Merged
merged 1 commit into from
Dec 24, 2024
Merged

🐛 Mark Web Vitals attribution fields as optional where appropriate #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/cjs/generated/rum.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,11 +1506,11 @@ export interface ViewPerformanceData {
/**
* Timestamp in ns of the largest layout shift contributing to CLS
*/
readonly timestamp: number;
readonly timestamp?: number;
/**
* CSS selector path of the first element (in document order) of the largest layout shift contributing to CLS
*/
readonly target_selector: string;
readonly target_selector?: string;
[k: string]: unknown;
};
/**
Expand Down Expand Up @@ -1538,7 +1538,7 @@ export interface ViewPerformanceData {
/**
* CSS selector path of the first input target element
*/
readonly target_selector: string;
readonly target_selector?: string;
[k: string]: unknown;
};
/**
Expand All @@ -1552,11 +1552,11 @@ export interface ViewPerformanceData {
/**
* Timestamp in ns of the start of the INP interaction
*/
readonly timestamp: number;
readonly timestamp?: number;
/**
* CSS selector path of the interacted element for the INP interaction
*/
readonly target_selector: string;
readonly target_selector?: string;
[k: string]: unknown;
};
/**
Expand All @@ -1570,7 +1570,7 @@ export interface ViewPerformanceData {
/**
* CSS selector path of the largest contentful paint element
*/
readonly target_selector: string;
readonly target_selector?: string;
[k: string]: unknown;
};
[k: string]: unknown;
Expand Down
12 changes: 6 additions & 6 deletions lib/esm/generated/rum.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,11 +1506,11 @@ export interface ViewPerformanceData {
/**
* Timestamp in ns of the largest layout shift contributing to CLS
*/
readonly timestamp: number;
readonly timestamp?: number;
/**
* CSS selector path of the first element (in document order) of the largest layout shift contributing to CLS
*/
readonly target_selector: string;
readonly target_selector?: string;
[k: string]: unknown;
};
/**
Expand Down Expand Up @@ -1538,7 +1538,7 @@ export interface ViewPerformanceData {
/**
* CSS selector path of the first input target element
*/
readonly target_selector: string;
readonly target_selector?: string;
[k: string]: unknown;
};
/**
Expand All @@ -1552,11 +1552,11 @@ export interface ViewPerformanceData {
/**
* Timestamp in ns of the start of the INP interaction
*/
readonly timestamp: number;
readonly timestamp?: number;
/**
* CSS selector path of the interacted element for the INP interaction
*/
readonly target_selector: string;
readonly target_selector?: string;
[k: string]: unknown;
};
/**
Expand All @@ -1570,7 +1570,7 @@ export interface ViewPerformanceData {
/**
* CSS selector path of the largest contentful paint element
*/
readonly target_selector: string;
readonly target_selector?: string;
[k: string]: unknown;
};
[k: string]: unknown;
Expand Down
8 changes: 4 additions & 4 deletions schemas/rum/_view-performance-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"cls": {
"type": "object",
"description": "Cumulative Layout Shift",
"required": ["score", "timestamp", "target_selector"],
"required": ["score"],
"properties": {
"score": {
"type": "number",
Expand Down Expand Up @@ -51,7 +51,7 @@
"fid": {
"type": "object",
"description": "First Input Delay",
"required": ["duration", "timestamp", "target_selector"],
"required": ["duration", "timestamp"],
"properties": {
"duration": {
"type": "integer",
Expand Down Expand Up @@ -79,7 +79,7 @@
"inp": {
"type": "object",
"description": "Interaction to Next Paint",
"required": ["duration", "timestamp", "target_selector"],
"required": ["duration"],
"properties": {
"duration": {
"type": "integer",
Expand Down Expand Up @@ -107,7 +107,7 @@
"lcp": {
"type": "object",
"description": "Largest Contentful Paint",
"required": ["timestamp", "target_selector"],
"required": ["timestamp"],
"properties": {
"timestamp": {
"type": "integer",
Expand Down
Loading