Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-124: verify_object Update #132

Merged
merged 21 commits into from
Sep 12, 2024
Merged

Feature-124: verify_object Update #132

merged 21 commits into from
Sep 12, 2024

Commits on Sep 10, 2024

  1. Fix formatting inconsistencies caused due to pycharm settings

    @doulikecookiedough
    doulikecookiedough committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    32b9db8 View commit details
    Browse the repository at this point in the history

  2. Update 'delete_object' in hashstore interface to only accept a pid

    @doulikecookiedough
    doulikecookiedough committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7cda167 View commit details
    Browse the repository at this point in the history

  3. Refactor 'delete_object' by extracting method 'delete_object_only' an… 

    …d update signature to match the updated interface
    @doulikecookiedough
    doulikecookiedough committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2d674a4 View commit details
    Browse the repository at this point in the history

  4. Add docstring to 'delete_object_only' method and re-organize pytests

    @doulikecookiedough
    doulikecookiedough committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1f5868d View commit details
    Browse the repository at this point in the history

  5. Re-organize 'delete_object_only' method in filehashstore

    @doulikecookiedough
    doulikecookiedough committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    dff873d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Extract '_get_hashstore_pid_refs_path' from '_resolve_path' and updat… 

    …e pytests
    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    eaabe3a View commit details
    Browse the repository at this point in the history

  2. Extract '_get_hashstore_cid_refs_path' from '_resolve_path' and updat… 

    …e pytests
    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d42d916 View commit details
    Browse the repository at this point in the history

  3. Extract '_get_hashstore_data_object_path' from '_resolve_path'

    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d94b39c View commit details
    Browse the repository at this point in the history

  4. Extract '_get_hashstore_metadata_path' from '_resolve_path'

    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    232cd4d View commit details
    Browse the repository at this point in the history

  5. Delete '_resolve_path' method and refactor affected code and pytests

    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7ed22b4 View commit details
    Browse the repository at this point in the history

  6. Rename '_build_path' to '_build_hashstore_data_object_path' and updat… 

    …e pytests
    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    aabb690 View commit details
    Browse the repository at this point in the history

  7. Refactor '_build_hashstore_data_object_path' by removing redundant si… 

    …gnature value
    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    2321b6f View commit details
    Browse the repository at this point in the history

  8. Clean up '_get_hashstore_data_object_path' and '_get_hashstore_metada… 

    …ta_path' for clarity
    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5446ee3 View commit details
    Browse the repository at this point in the history

  9. Add context and revise '_shard' docstring so that it is easier to und… 

    …erstand
    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    4218560 View commit details
    Browse the repository at this point in the history

  10. Fix docstring length

    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5215cc4 View commit details
    Browse the repository at this point in the history

  11. Rename 'hashstore' public APi method 'verify_object' to 'delete_inval… 

    …id_object', revise docstrings, update filehashstore and revise/add new pytests
    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d1644d0 View commit details
    Browse the repository at this point in the history

  12. Make 'delete_object_only' a private method by renaming it to '_delete… 

    …_object_only' and update pytests
    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7535949 View commit details
    Browse the repository at this point in the history

  13. Make 'find_object' a private method by renaming it to '_find_object' … 

    …and update pytests
    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ca3f1b8 View commit details
    Browse the repository at this point in the history

  14. Revise docstrings to resolve linting warnings

    @doulikecookiedough
    doulikecookiedough committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    93d81eb View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Cleanup pytests for unused and redundant code

    @doulikecookiedough
    doulikecookiedough committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    79ab4f0 View commit details
    Browse the repository at this point in the history

  2. Clean up methods '_store_data_only', '_find_object' and '_store_and_v… 

    …alidate_data' and review/revise/add pytests
    @doulikecookiedough
    doulikecookiedough committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    791c17e View commit details
    Browse the repository at this point in the history