Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

535 system test #618

Merged
merged 9 commits into from
Sep 9, 2024
Merged

535 system test #618

merged 9 commits into from
Sep 9, 2024

Conversation

ZohebShaikh
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.48%. Comparing base (09f65fe) to head (9b921c2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/blueapi/client/rest.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
- Coverage   92.52%   92.48%   -0.04%     
==========================================
  Files          35       35              
  Lines        1632     1637       +5     
==========================================
+ Hits         1510     1514       +4     
- Misses        122      123       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DiamondJoseph DiamondJoseph mentioned this pull request Sep 5, 2024
Copy link
Collaborator

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in #611 (review)

src/blueapi/client/client.py Outdated Show resolved Hide resolved
tests/unit_tests/test_cli.py Show resolved Hide resolved
src/blueapi/client/client.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@ZohebShaikh ZohebShaikh dismissed callumforrester’s stale review September 9, 2024 13:09

The requested changes have been addressed

@ZohebShaikh ZohebShaikh merged commit 0760630 into main Sep 9, 2024
25 of 26 checks passed
@ZohebShaikh ZohebShaikh deleted the 535-system-test branch September 9, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants