Add system tests #611
Closed
Add system tests #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e bluesky stomp library
Closes #597 --------- Co-authored-by: Callum Forrester <callum.forrester@diamond.ac.uk>
Closed
ZohebShaikh
force-pushed
the
535-system-tests
branch
from
9e70c3e
to
aef0f7d
Compare
ZohebShaikh
force-pushed
the
535-system-tests
branch
from
aef0f7d
to
bcc8e57
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 92.52% 92.52% -0.01%
==========================================
Files 35 35
Lines 1633 1632 -1
==========================================
- Hits 1511 1510 -1
Misses 122 122 ☔ View full report in Codecov by Sentry. |
|
I have not move the current test to unit test will move after #589 is merge ... |
ZohebShaikh
force-pushed
the
535-system-tests
branch
from
b9bb6dd
to
15a5c93
Compare
Closed
callumforrester
requested changes
Sep 5, 2024
| created_task = rest.create_task(task) | ||
| created_tasks.append(created_task) | ||
|
|
||
| task_list = get_response(rest._url("/tasks"), TasksListResponse) |
There was a problem hiding this comment.
I'm unsure why the client object doesn't provide what you want here
There was a problem hiding this comment.
I have added code for this here b5bb825
I think we should change
get_task(task_id) to get_task_by_id(task_id) -> assert task_id is not ""
and get_all_tasks()
There was a problem hiding this comment.
It was added by this #508
|
Replaced by #618 for neatness |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.