Defer implementation of MsgGenerator to prevent strange behaviour #832
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it has been observed in blueapi that defining the same type alias in different modules has stopped being the same object, and then later stopped even being equal to each other. As checking that the return type of a function is
MsgGenerator
is used by blueapi to determine which plans to expose, this has prevented plans and stubs from being visible. As of bluesky 1.13, bluesky now defines its own implementation of MsgGenerator, which also meets the requirements of @rtuck99 of having a return type.Prevents re-occurence of these issues and similar:
DiamondLightSource/blueapi#533
DiamondLightSource/blueapi#643
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}