Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer to bluesky.utils MsgGenerator #564

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Defer to bluesky.utils MsgGenerator #564

wants to merge 2 commits into from

Conversation

DiamondJoseph
Copy link
Contributor

@DiamondJoseph DiamondJoseph commented Oct 10, 2024 •
edited
Loading

Companion change to DiamondLightSource/dodal#832

@DiamondJoseph DiamondJoseph mentioned this pull request Oct 10, 2024
Merged
4 tasks
DominicOram
DominicOram requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test failure is real and implies that blueAPI is not picking up plans annotated with the MsgGenerator from bluesky. Do we need to update blueAPI as part of this?

@DominicOram DominicOram mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominicOram DominicOram DominicOram requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DiamondJoseph @DominicOram