Hotfixes found from testing on the beamline #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
requested review from
rtuck99,
noemifrisina,
dperl-dls and
olliesilvester
This was referenced Sep 12, 2024
rtuck99
reviewed
Sep 16, 2024
| @@ -77,6 +78,7 @@ class RobotLoadThenCentreComposite: | |||
| panda: HDFPanda | |||
| panda_fast_grid_scan: PandAFastGridScan | |||
| thawer: Thawer | |||
| sample_shutter: ZebraShutter | |||
There was a problem hiding this comment.
Maybe we should use python protocols more then we wouldn't run into this kind of issue as much as it would be picked up by static analysis
There was a problem hiding this comment.
Yh, we need a better way of managing it. If you have an idea can you add it to #287?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463
To test:
mx-blueskydirectory to something different, run./utility_scripts/dls_dev_env.shand confirm it still works