Miscellaneous kubernetes deployment fixes #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rtuck99
commented
Sep 18, 2024
rtuck99
commented
- Enable hostNetwork in helmchart in order to access instrumentation network
- Fix version extraction from folder path
- Change image name to mx-bluesky to match the release CI workflow
- Fix helmchart default log folder to not clash with non-containerised version
- Do final docker image pip install with no-deps to prevent editable dodal being clobbered
* Enable hostNetwork to helmchart in order to access instrumentation network * Fix version extraction from folder path * Change helmchart image name to mx-bluesky to match the release CI workflow * Fix helmchart default log folder to not clash with non-containerised version * Do final docker image pip install with no-deps to prevent editable dodal being clobbered
DominicOram
approved these changes
Sep 20, 2024
| @@ -111,3 +150,4 @@ spec: | |||
| name: logs | |||
| - mountPath: "/dls/{{ .Values.hyperion.beamline }}/data" | |||
| name: data | |||
| hostNetwork: true | |||
There was a problem hiding this comment.
@callumforrester or @DiamondJoseph why do we need this to talk to EPICS but blueapi seems fine without it?
Comment on lines
+64
to
+99
| drop: | ||
| - AUDIT_WRITE | ||
| - CHOWN | ||
| - DAC_OVERRIDE | ||
| - FOWNER | ||
| - FSETID | ||
| - KILL | ||
| - MKNOD | ||
| - NET_BIND_SERVICE | ||
| - NET_RAW | ||
| - SETFCAP | ||
| - SETGID | ||
| - SETPCAP | ||
| - SETUID | ||
| - SYS_CHROOT | ||
| - AUDIT_CONTROL | ||
| - BLOCK_SUSPEND | ||
| - DAC_READ_SEARCH | ||
| - IPC_LOCK | ||
| - IPC_OWNER | ||
| - LEASE | ||
| - LINUX_IMMUTABLE | ||
| - MAC_ADMIN | ||
| - MAC_OVERRIDE | ||
| - SYS_ADMIN | ||
| - SYS_BOOT | ||
| - SYS_MODULE | ||
| - SYS_NICE | ||
| - SYS_PACCT | ||
| - SYS_MODULE | ||
| - SYS_PTRACE | ||
| - SYS_RESOURCE | ||
| - SYS_TIME | ||
| - SYS_TTY_CONFIG | ||
| - SYSLOG | ||
| - WAKE_ALARM |
There was a problem hiding this comment.
Should: As discussed, this may not be necessary or it may be better to drop ALL. Can you make an issue to chase up, feel free to add other k8s tidying to that issue if you think there's some needed?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 77.90% 77.90%
=======================================
Files 89 89
Lines 6711 6711
=======================================
Hits 5228 5228
Misses 1483 1483
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.