Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve automated Zooma mappings #411

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

apriltuesday
Copy link
Contributor

@apriltuesday apriltuesday commented Jan 17, 2024

Allow mappings to be considered finished (i.e. not needing curation) if they are exact string matches to terms in the target ontology, even if not determined to be high confidence. Also make the trait processing case insensitive as apparently Zooma itself is not!

Related to EBIvariation/opentargets-pharmgkb#30

@apriltuesday apriltuesday marked this pull request as ready for review January 17, 2024 15:02
@apriltuesday apriltuesday self-assigned this Jan 17, 2024
Copy link
Member

@tcezard tcezard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

cmat/trait_mapping/trait.py Outdated Show resolved Hide resolved
@apriltuesday apriltuesday requested a review from tcezard January 23, 2024 11:39
@apriltuesday apriltuesday merged commit 0f5c976 into EBIvariation:master Jan 23, 2024
1 check passed
@apriltuesday apriltuesday deleted the automated-mappings branch January 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants