Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify counts for when evidence is invalid #419

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Modify counts for when evidence is invalid #419

merged 3 commits into from
Feb 7, 2024

Conversation

apriltuesday
Copy link
Contributor

@apriltuesday apriltuesday commented Feb 7, 2024 •
edited
Loading

This should properly count RCVs that only generate invalid evidence as skipped.

@apriltuesday apriltuesday self-assigned this Feb 7, 2024
@apriltuesday apriltuesday requested a review from tcezard February 7, 2024 10:32
tcezard
tcezard approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@tcezard tcezard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I guess the only other rhing we need to do is record the number of invalid evidence in the spreadsheet.

cmat/output_generation/clinvar_to_evidence_strings.py Outdated Show resolved Hide resolved
@apriltuesday apriltuesday merged commit 0bfba70 into EBIvariation:master Feb 7, 2024
1 check passed
@apriltuesday apriltuesday deleted the feb-hotfix branch August 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcezard tcezard tcezard approved these changes

Assignees

@apriltuesday apriltuesday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apriltuesday @tcezard