Issue 416 - Parallelise evidence string generation #421
Conversation
| def dump_to_file(self, dir_out, filename=COUNTS_FILE_NAME): | ||
| with open(os.path.join(dir_out, filename), 'w') as f: | ||
| yaml.safe_dump(vars(self), f) | ||
|
|
||
| def load_from_file(self, filename): | ||
| with open(filename, 'r') as f: | ||
| data = yaml.safe_load(f) | ||
| self.__dict__.update(**data) | ||
| # yaml loads a dict, convert to counter | ||
| self.unmapped_trait_names = Counter(self.unmapped_trait_names) |
There was a problem hiding this comment.
I was going to say that pickling the objet might be safer but I 'm guessing that you want to use the final output yaml elsewhere?
There was a problem hiding this comment.
Yes, I was thinking having it in yaml might be more readable and flexible for downstream purposes (e.g. updating the metrics or generating sankey diagrams), but it's probably overkill if those processes end up implemented in Python anyway... I'd probably keep it as it is for now.
|
Counts from test run match last submission, aside from a very silly error that I just fixed. |
Closes #416
Closes #420