Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model for ClinVar submitted records (SCVs) #442

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

apriltuesday
Copy link
Contributor

No description provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to clinvar_xml_io

@property
def submission_name(self):
"""Name or identifier associated with the submission. This is optional."""
return self.record_xml.attrib.get('SubmissionName', None)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be used for the gene-related condition filtering, confirmed it's present in that case

@apriltuesday apriltuesday marked this pull request as ready for review August 19, 2024 11:10
@apriltuesday apriltuesday self-assigned this Aug 19, 2024
@apriltuesday apriltuesday requested a review from tcezard August 19, 2024 11:10
@apriltuesday apriltuesday requested a review from tcezard August 21, 2024 13:04
Copy link
Member

@tcezard tcezard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@apriltuesday apriltuesday merged commit 86cc604 into EBIvariation:master Aug 22, 2024
1 check passed
@apriltuesday apriltuesday deleted the scv-model branch August 22, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants