Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 434: Add VCV IDs to evidence strings #444

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Issue 434: Add VCV IDs to evidence strings #444

merged 6 commits into from
Oct 17, 2024

Conversation

apriltuesday
Copy link
Contributor

Closes #434

@apriltuesday
Copy link
Contributor Author

End-to-end tests will pass once the OT schema is updated.

@apriltuesday apriltuesday marked this pull request as ready for review September 18, 2024 11:02
@apriltuesday apriltuesday self-assigned this Sep 18, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11388051944

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 80.613%
Files with Coverage Reduction New Missed Lines %
cmat/trait_mapping/main.py 1 96.2%
cmat/output_generation/evaluation/ols_utils.py 1 86.67%
Totals Coverage Status
Change from base Build 11291074079: -0.05%
Covered Lines: 1867
Relevant Lines: 2316
💛 - Coveralls

@apriltuesday apriltuesday merged commit b4fdf36 into EBIvariation:master Oct 17, 2024
1 check passed
@apriltuesday apriltuesday deleted the add-vcv-id branch October 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcezard tcezard tcezard approved these changes

Assignees

@apriltuesday apriltuesday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add VCV IDs to evidence strings
3 participants
@apriltuesday @coveralls @tcezard