Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-3445 After recovering the block they should be saved #79

Merged
merged 1 commit into from
Nov 21, 2023
Merged

EVA-3445 After recovering the block they should be saved #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...a/src/main/java/uk/ac/ebi/ampt2d/commons/accession/generators/monotonic/BlockManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ private void doRelease(long[] accessions) {
* @param committedElements Accessions that have already been committed
* @throws AccessionIsNotPendingException When the generated accession does not match with the accession to commit
*/
public void recoverState(long[] committedElements) throws AccessionIsNotPendingException {
public Set<ContiguousIdBlock> recoverState(long[] committedElements) throws AccessionIsNotPendingException {
List<MonotonicRange> ranges = MonotonicRange.convertToMonotonicRanges(committedElements);
List<MonotonicRange> newAvailableRanges = new ArrayList<>();
for (MonotonicRange monotonicRange : this.availableRanges) {
Expand All @@ -166,6 +166,6 @@ public void recoverState(long[] committedElements) throws AccessionIsNotPendingE

this.availableRanges.clear();
this.availableRanges.addAll(newAvailableRanges);
doCommit(committedElements);
return doCommit(committedElements);
}
}
2 changes: 1 addition & 1 deletion .../uk/ac/ebi/ampt2d/commons/accession/generators/monotonic/MonotonicAccessionGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ private static void assertBlockParametersAreInitialized(ContiguousIdBlockService
* @throws AccessionIsNotPendingException
*/
private void recoverState(long[] committedElements) throws AccessionIsNotPendingException {
blockManager.recoverState(committedElements);
blockService.save(blockManager.recoverState(committedElements));
}

public synchronized long[] generateAccessions(int numAccessionsToGenerate)
Expand Down
Loading